PDFCLOUD-5555 Add zip and unzip client methods#20
Merged
datalogics-tsmith merged 5 commits intopdfrest:mainfrom Feb 18, 2026
Merged
PDFCLOUD-5555 Add zip and unzip client methods#20datalogics-tsmith merged 5 commits intopdfrest:mainfrom
datalogics-tsmith merged 5 commits intopdfrest:mainfrom
Conversation
datalogics-cgreen
changed the title
Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
datalogics-cgreen
force-pushed
the
pdfcloud-5464-zip
branch
from
3ded244 to
ceab978
Compare
Note use of `noqa: S105` in test_unzip_file.py. This is to silence warnings over a test password value used only in testing. Assisted-by: Codex
datalogics-cgreen
force-pushed
the
pdfcloud-5464-zip
branch
from
ceab978 to
d2ca8b3
Compare
datalogics-kam
approved these changes
Feb 16, 2026
Contributor
datalogics-kam
left a comment
datalogics-kam
left a comment
There was a problem hiding this comment.
Approved, with some tests added by Codex.
Contributor
Author
|
I'll merge this following the next rebase. Certain restrictions forbid me from doing so right now. |
- Introduced async tests for `unzip_file`:
- `test_async_unzip_file_requires_zip`: Verifies validation for non-ZIP input.
- `test_async_unzip_file_single_input`: Ensures validation for single ZIP
file restriction.
- Introduced async tests for `zip_files`:
- `test_async_zip_files_request_customization`: Validates request customization
with query parameters, headers, body data, and timeout configuration.
- `test_async_zip_files_requires_input`: Checks validation for empty input.
- `test_async_zip_files_rejects_invalid_output`: Ensures validation for
invalid output file names.
- Mocked API transport for all tests to simulate responses and validate
exception handling.
Assisted-by: Codex
datalogics-cgreen
force-pushed
the
pdfcloud-5464-zip
branch
from
0ba3f88 to
b68d8c3
Compare
datalogics-tsmith
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces client support for ZIP and Unzip tools/endpoints.
Adds unit tests covering both ZIP and Unzip functionality.
Ensures feature parity by pairing each new endpoint with dedicated tests.